[webkit-reviews] review requested: [Bug 49355] WebGLRenderingContext needs to zero textures and renderbuffers : [Attachment 75761] revised patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 6 17:34:12 PST 2010


Zhenyao Mo <zmo at google.com> has asked  for review:
Bug 49355: WebGLRenderingContext needs to zero textures and renderbuffers
https://bugs.webkit.org/show_bug.cgi?id=49355

Attachment 75761: revised patch
https://bugs.webkit.org/attachment.cgi?id=75761&action=review

------- Additional Comments from Zhenyao Mo <zmo at google.com>
Removing all the cases where pixels==null is passed to
GraphicsContext3D::texImagde2D().

Per discussion with kbr, now an INVALID_VALUE is generated in
GraphicsContext3D::texImagde2D if pixels==null.

Tested in linux with --platform chromium-gpu and it's no longer crashing.


More information about the webkit-reviews mailing list