[webkit-reviews] review granted: [Bug 49938] ApplyStyleCommand should take EditingStyle instead of CSSStyleDeclaration : [Attachment 75224] fixed per Tony's & Darin's comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 6 14:25:54 PST 2010


Tony Chang <tony at chromium.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 49938: ApplyStyleCommand should take EditingStyle instead of
CSSStyleDeclaration
https://bugs.webkit.org/show_bug.cgi?id=49938

Attachment 75224: fixed per Tony's & Darin's comments
https://bugs.webkit.org/attachment.cgi?id=75224&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=75224&action=review

Darin may want to comment on the function name overrideWithStyle.

> WebCore/ChangeLog:10
> +	   by calls to EditingStyle's member functions and extracted
EditingStyle::overrideWith and

Nit: overrideWithStyle


More information about the webkit-reviews mailing list