[webkit-reviews] review granted: [Bug 50583] Add a shim for GetCurrentEventButtonState : [Attachment 75732] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 50583: Add a shim for GetCurrentEventButtonState
https://bugs.webkit.org/show_bug.cgi?id=50583

Attachment 75732: Patch
https://bugs.webkit.org/attachment.cgi?id=75732&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=75732&action=review

> WebKit2/WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:431
>	       EventRecord event = initializeEventRecord(eventKind);
> +	       event.modifiers = modifiersForEvent(mouseEvent);
>	       event.where.h = mouseEvent.globalPosition().x();
>	       event.where.v = mouseEvent.globalPosition().y();
> +
>	       return NPP_HandleEvent(&event);

This seems unrelated to the rest of your patch. Your ChangeLog doesn't mention
it either.

Is it possible to add a test that shows this was missing before?