[webkit-reviews] review denied: [Bug 50581] Make TestResultsServer return empty JSON or 404 for non-existing results files : [Attachment 75726] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 6 12:32:43 PST 2010
Ojan Vafai <ojan at chromium.org> has denied Kinuko Yasuda <kinuko at chromium.org>'s
request for review:
Bug 50581: Make TestResultsServer return empty JSON or 404 for non-existing
results files
https://bugs.webkit.org/show_bug.cgi?id=50581
Attachment 75726: Patch
https://bugs.webkit.org/attachment.cgi?id=75726&action=review
------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=75726&action=review
> WebKitTools/TestResultServer/handlers/testfilehandler.py:118
> + return EMPTY_JSON_FORMAT % builder
Why do we want to do this instead of handling None at the calling location?
Don't we want to 404 in this case as well?
More information about the webkit-reviews
mailing list