[webkit-reviews] review granted: [Bug 47300] Executing FormatBlock on multiple paragraphs inside pre does not remove the outer pre : [Attachment 75640] fixes the bug

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 47300: Executing FormatBlock on multiple paragraphs inside pre does not
remove the outer pre
https://bugs.webkit.org/show_bug.cgi?id=47300

Attachment 75640: fixes the bug
https://bugs.webkit.org/attachment.cgi?id=75640&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=75640&action=review

> WebCore/editing/FormatBlockCommand.h:48
> -    void formatRange(const Position&, const Position&, RefPtr<Element>&);
> +    void formatRange(const Position&, const Position&, const Position&
endOfSelection, RefPtr<Element>&);

Nit: Should we name the first and second Position params like in
ApplyBlockElementCommand.h?

> WebCore/editing/IndentOutdentCommand.h:56
> -    void formatRange(const Position&, const Position&, RefPtr<Element>&
blockquoteForNextIndent);
> +    void formatRange(const Position&, const Position&, const Position&
endOfSelection, RefPtr<Element>& blockquoteForNextIndent);

Nit: Should we name the first and second Position params like in
ApplyBlockElementCommand.h?