[webkit-reviews] review granted: [Bug 47490] [Qt] Mock DeviceOrientation client for DRT : [Attachment 75492] Patch v3

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Diego Gonzalez
<diegohcg at webkit.org>'s request for review:
Bug 47490: [Qt] Mock DeviceOrientation client for DRT
https://bugs.webkit.org/show_bug.cgi?id=47490

Attachment 75492: Patch v3
https://bugs.webkit.org/attachment.cgi?id=75492&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=75492&action=review

> WebKit/qt/WebCoreSupport/DeviceOrientationClientMockQt.cpp:48
> +    delete m_clientMock;

cant this be an OwnPtr? If not this is ok

> WebKit/qt/WebCoreSupport/DeviceOrientationClientMockQt.h:46
> +    static bool drtActive;

static bool mockIsActive would be more descriptive.