[webkit-reviews] review granted: [Bug 49564] createSVGTransformFromMatrix(undefined) => NULL ptr : [Attachment 75630] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Dec 5 11:54:30 PST 2010
Nikolas Zimmermann <zimmermann at kde.org> has granted Rob Buis
<rwlbuis at gmail.com>'s request for review:
Bug 49564: createSVGTransformFromMatrix(undefined) => NULL ptr
https://bugs.webkit.org/show_bug.cgi?id=49564
Attachment 75630: Patch
https://bugs.webkit.org/attachment.cgi?id=75630&action=review
------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=75630&action=review
Excellent, please fix the style issues before landing, r=me.
> WebCore/svg/properties/SVGTransformListPropertyTearOff.h:43
> + if (!matrix) { ec = TYPE_MISMATCH_ERR; return 0; }
Each new statement should go into its own line.
More information about the webkit-reviews
mailing list