[webkit-reviews] review denied: [Bug 46095] MacroAssemblerARM generates unaligned loads : [Attachment 68235] Add new setTest32 with RegisterID parameter
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Dec 4 16:04:53 PST 2010
Gavin Barraclough <barraclough at apple.com> has denied David Tapuska
<dtapuska at rim.com>'s request for review:
Bug 46095: MacroAssemblerARM generates unaligned loads
https://bugs.webkit.org/show_bug.cgi?id=46095
Attachment 68235: Add new setTest32 with RegisterID parameter
https://bugs.webkit.org/attachment.cgi?id=68235&action=review
------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
Hi David,
These methods had been rather poorly named, and it was rather unclear what they
were doing. I've hopefully just cleared this up a little:
https://bugs.webkit.org/show_bug.cgi?id=50509
Looking at your patch, I think your changes to (the method previously known as)
setTest8 are correct, but the change to set8 is incorrect, and should be
reverted.
Please update & check your change.
cheers,
G.
More information about the webkit-reviews
mailing list