[webkit-reviews] review granted: [Bug 50500] Teach webkit-patch how to search bugzilla : [Attachment 75587] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 50500: Teach webkit-patch how to search bugzilla
https://bugs.webkit.org/show_bug.cgi?id=50500

Attachment 75587: Patch
https://bugs.webkit.org/attachment.cgi?id=75587&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=75587&action=review

> WebKitTools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py:86
> +	   if result_count_parts[0] == "Zarro":
> +	       return 0

Zarro!

> WebKitTools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py:106
> +	   self._bugzilla.browser.select_form(predicate=self._is_xml_bugs_form)

> +	   bugs_xml = self._bugzilla.browser.submit()

:(

Can we at least assert that self._bugzilla is in the proper state.

> WebKitTools/Scripts/webkitpy/tool/commands/bugsearch.py:33
> +    name = "bug-search"

search-bugs maybe?

> WebKitTools/Scripts/webkitpy/tool/commands/bugsearch.py:40
> +	       print "%5s %s" % (bug.id(), bug.title())

What happens when we get six digit buts?

> WebKitTools/Scripts/webkitpy/tool/commands/bugsearch.py:42
> +	       print "No bugs found matching '%s'" % search_string

zarro!