[webkit-reviews] review granted: [Bug 50246] [v8] put all the implicitly reachable style elements into single v8 group : [Attachment 75534] WebKit hacking from Chromium checkout over ssh sucks

[bugzilla-daemon at webkit.org]

Nate Chapin <japhet at chromium.org> has granted anton muhin
<antonm at chromium.org>'s request for review:
Bug 50246: [v8] put all the implicitly reachable style elements into single v8
group
https://bugs.webkit.org/show_bug.cgi?id=50246

Attachment 75534: WebKit hacking from Chromium checkout over ssh sucks
https://bugs.webkit.org/attachment.cgi?id=75534&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=75534&action=review

> WebCore/ChangeLog:22
> +	   (WebCore::ObjectGrouperVisitor::ObjectGrouperVisitor):
> +	   (WebCore::ObjectGrouperVisitor::startMap):
> +	   (WebCore::ObjectGrouperVisitor::endMap):
> +	   (WebCore::ObjectGrouperVisitor::visitDOMWrapper):

Nit: this didn't get changed to DOMObjectGrouperVisitor.

> WebCore/bindings/v8/V8GCController.cpp:385
> +	   StyleBase* styleBase = static_cast<StyleBase*>(object);
>  
> -	       ASSERT(i == nextKeyIndex);
> +	   // We put the whole tree of style elements into a single object
group.
> +	   // To achieve that we group elements by the roots of their trees.
> +	   StyleBase* root = styleBase;

I wish there were a way for this code to be clear without needing styleBase as
a separate variable (it's only use is to initialize root), but I don't
immediately see what it is.