[webkit-reviews] review granted: [Bug 50484] Rebaseline server: use pretty text diff output : [Attachment 75540] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Mihai Parparita
<mihaip at chromium.org>'s request for review:
Bug 50484: Rebaseline server: use pretty text diff output
https://bugs.webkit.org/show_bug.cgi?id=50484

Attachment 75540: Patch
https://bugs.webkit.org/attachment.cgi?id=75540&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=75540&action=review

> WebKitTools/Scripts/webkitpy/tool/commands/rebaselineserver.py:177
> +	   elif mode == 'diff-text-pretty':
> +	       file_name = test_name + '-pretty-diff.html'

I normally use dictionaries for stuff like this. E.g.:
suffix = { 'expected-text': '-expected.txt',
  'actual-text': '-actual.txt',
  ...
}[mode]
file_name = test_name + suffix

But I don't feel strongly about it and this case is a bit awkward because it's
a suffix.