[webkit-reviews] review denied: [Bug 50482] Crash trying to empty caches with no WebProcess. : [Attachment 75538] Proprosed fix v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 3 13:53:38 PST 2010


Sam Weinig <sam at webkit.org> has denied Brady Eidson <beidson at apple.com>'s
request for review:
Bug 50482: Crash trying to empty caches with no WebProcess.
https://bugs.webkit.org/show_bug.cgi?id=50482

Attachment 75538: Proprosed fix v1
https://bugs.webkit.org/attachment.cgi?id=75538&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=75538&action=review

> WebKit2/UIProcess/WebContext.cpp:182
> +    if (m_clearResourceCachesForNewWebProcess) {
> +	   m_process->send(Messages::WebProcess::ClearResourceCaches(), 0);
> +	   m_clearResourceCachesForNewWebProcess = false;
> +    }
> +    
> +    if (m_clearApplicationCacheForNewWebProcess) {
> +	   m_process->send(Messages::WebProcess::ClearApplicationCache(), 0);
> +	   m_clearApplicationCacheForNewWebProcess = false;
> +    }

This should use the process initialization message idiom used above in this
function, instead of sending its own messages.


More information about the webkit-reviews mailing list