[webkit-reviews] review denied: [Bug 45318] Complex Path FontCache does not handle SmallCaps properly : [Attachment 66916] Updated patch with LayoutTests

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Gary Simmons <gsimmons at rim.com>'s
request for review:
Bug 45318: Complex Path FontCache does not handle SmallCaps properly
https://bugs.webkit.org/show_bug.cgi?id=45318

Attachment 66916: Updated patch with LayoutTests
https://bugs.webkit.org/attachment.cgi?id=66916&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=66916&action=review

> LayoutTests/ChangeLog:5
> +	   Load the same font twice once as small caps and the second time as
plain to ensure that small caps

Your changelog should mention the bug.	prepare-ChangeLog -b NUMBER will fill
it in for you.	As would webkit-patch upload.

> WebCore/ChangeLog:5
> +	   Add smallCaps to the Font Cache key to allow differentiating between
plain and small caps variants o 	   fonts when running text through the
non-fast path code such as in the Qt port.

misformating.  Also missing bug here.

> WebCore/platform/graphics/FontCache.cpp:59
> +				bool smallCaps = false, bool isPrinterFont =
false, FontRenderingMode renderingMode = NormalRenderingMode)

bools are strictly worse than enums.  Enums make callsites much clearer.