[webkit-reviews] review granted: [Bug 48429] [Gtk] Populate DumpRenderTreeSupportGtk : [Attachment 75526] patch v2.3 - rebased to ToT

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Antonio Gomes
<tonikitoo at webkit.org>'s request for review:
Bug 48429: [Gtk] Populate DumpRenderTreeSupportGtk
https://bugs.webkit.org/show_bug.cgi?id=48429

Attachment 75526: patch v2.3 - rebased to ToT
https://bugs.webkit.org/attachment.cgi?id=75526&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=75526&action=review

Looks good! Some of the methods are named slightly differently than others.
It's not a huge deal though.

> WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:106
> +GSList* DumpRenderTreeSupportGtk::getChildren(WebKitWebFrame* frame)

It might make sense to call this getFrameChildren, since it's no longer a
method of the frame.

> WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:223
> +int DumpRenderTreeSupportGtk::numberOfPages(WebKitWebFrame* frame, float
pageWidth, float pageHeight)

Maybe numberOfPagesForFrame?