[webkit-reviews] review granted: [Bug 50451] [GTK] Drop GdkDrawable usage, it's deprecated in GTK+3.x and we can use GdkWindow : [Attachment 75504] drawable.diff

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 50451: [GTK] Drop GdkDrawable usage, it's deprecated in GTK+3.x and we can
use GdkWindow
https://bugs.webkit.org/show_bug.cgi?id=50451

Attachment 75504: drawable.diff
https://bugs.webkit.org/attachment.cgi?id=75504&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=75504&action=review

I tested this patch locally with exceptional results. But unless I'm crazy, I
think that the change to the comment is incorrect.

> WebCore/platform/gtk/WidgetRenderingContextGtk2.cpp:91
> +    // paint directly to the target window. This will not render CSS
rotational transforms properly.

This comment is actually correct, because m_target may either be a GdkWindow or
a GdkPixmap, both of which are drawables. I don' think a pixmap is a window
though.