[webkit-reviews] review requested: [Bug 40511] Implement HTML5 hidden attribute : [Attachment 75482] Patch

[bugzilla-daemon at webkit.org]

Peter Beverloo <peter at lvp-media.com> has asked	for review:
Bug 40511: Implement HTML5 hidden attribute
https://bugs.webkit.org/show_bug.cgi?id=40511

Attachment 75482: Patch
https://bugs.webkit.org/attachment.cgi?id=75482&action=review

------- Additional Comments from Peter Beverloo <peter at lvp-media.com>
Re-baselined Maciej patch after brief discussion on IRC. Left the changelog
messages intact as I didn't change anything.

Something I did notice was that HTMLEmbedElement.cpp (line 108) already
implemented the hidden attribute in a slightly different way, by setting the
width and height to zero. I haven't changed this because I don't know the
rationale behind the implementation, but given the following line from the
HTML5 specification it might be wise to create a (follow up?) patch to update
the element's implementation.

> The embed element is unaffected by the CSS 'display' property. The selected
> plugin is instantiated even if the element is hidden with a 'display:none'
> CSS style.

http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.
html#the-embed-element