[webkit-reviews] review requested: [Bug 50366] XPath lexer misinterprets expression starting with "div". : [Attachment 75461] Updated patch with exhaustive test and slight bug fix.

[bugzilla-daemon at webkit.org]

Yonathan Randolph <yonathan at gmail.com> has asked  for review:
Bug 50366: XPath lexer misinterprets expression starting with "div".
https://bugs.webkit.org/show_bug.cgi?id=50366

Attachment 75461: Updated patch with exhaustive test and slight bug fix.
https://bugs.webkit.org/attachment.cgi?id=75461&action=review

------- Additional Comments from Yonathan Randolph <yonathan at gmail.com>
I've done what you've asked for.

> -    if (isOperatorContext()) {
> +    if (isBinaryOperatorContext()) {
>	   if (name == "and") //### hash?
>	       return Token(AND);
> 
> I'm wondering what this ### comment is about.

I don't understand it either.

> I'd try to add as many tests as I can think of, even if redundant. Say,
"div/div", "(12) div 4" or "div + div".
I've begrudgingly made the test exhaustive (I think). Turns out this was
actually a good idea, because I found a case I didn't notice earlier: node test
immediately following comma.