[webkit-reviews] review granted: [Bug 50423] Crashes in Photo Booth at com.apple.JavaScriptCore: JSC::Heap::markRoots + 746 : [Attachment 75435] patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 50423: Crashes in Photo Booth at com.apple.JavaScriptCore:
JSC::Heap::markRoots + 746
https://bugs.webkit.org/show_bug.cgi?id=50423

Attachment 75435: patch
https://bugs.webkit.org/attachment.cgi?id=75435&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
I think you should also call synchronize in ~APICallbackShim.

Thread A could be running JS code, call out to a callback, release a lock (in
client code), then thread B could run, schedule a GC, exit the VM, release its
lock, then the callback in thread A could return from the callback & be running
inside JSC with a GC scheduled on thread B.

r+ with the fix.