[webkit-reviews] review granted: [Bug 50170] Need a WebKit2 Equivalent of WebSecurityOrigin : [Attachment 75428] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Jessie Berlin <jberlin at webkit.org>'s
request for review:
Bug 50170: Need a WebKit2 Equivalent of WebSecurityOrigin
https://bugs.webkit.org/show_bug.cgi?id=50170

Attachment 75428: Patch
https://bugs.webkit.org/attachment.cgi?id=75428&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=75428&action=review

You need to add this file to the WebKit2.pro as well.

> WebKit2/Shared/APIObject.h:70
> +	   TypeSecurityOrigin,

It seems like there may be use for this object in both processes, so maybe it
should go in Shared.

> WebKit2/UIProcess/API/C/WKSecurityOrigin.h:37
> +WK_EXPORT WKSecurityOriginRef WKSecurityOriginCreate(WKStringRef
databaseIdentifier);

I don't like the phrase databaseIdentifier here.

> WebKit2/UIProcess/API/C/WKSecurityOrigin.h:41
> +WK_EXPORT size_t WKSecurityOriginGetPort(WKSecurityOriginRef
securityOrigin);

I think it would be reasonable to return an unsigned short here since ports
can't be larger that that.