[webkit-reviews] review granted: [Bug 49388] Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations : [Attachment 75422] Patch fixing issues from the review and add 2 files

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Chris Marrin
<cmarrin at apple.com>'s request for review:
Bug 49388: Share code between Mac (CA) and Windows (CACF) GraphicsLayer
implementations
https://bugs.webkit.org/show_bug.cgi?id=49388

Attachment 75422: Patch fixing issues from the review and add 2 files
https://bugs.webkit.org/attachment.cgi?id=75422&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=75422&action=review

> WebCore/platform/graphics/ca/mac/PlatformCAAnimationMac.mm:234
> +bool PlatformCAAnimation::nonZeroBeginTimeFlag() const

I think this should be hasNonZeroBeginTimeFlag()

> WebCore/platform/graphics/ca/mac/PlatformCAAnimationMac.mm:242
> +    [m_animation.get() setValue:[NSNumber numberWithBool:value]
forKey:WKNonZeroBeginTimeFlag];
> +

Extra space.

> WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm:182
> +		   layerClass = NSClassFromString(@"CALayer");

[CALayer class] would be fine here, and faster.