[webkit-reviews] review requested: [Bug 50295] Regexp JIT'ed Code Contains Branches to Branches for Backtracking : [Attachment 75425] Updated patch addressing reviewers concerns and fixing a bug.

[bugzilla-daemon at webkit.org]

Michael Saboff <msaboff at apple.com> has asked  for review:
Bug 50295: Regexp JIT'ed Code Contains Branches to Branches for Backtracking
https://bugs.webkit.org/show_bug.cgi?id=50295

Attachment 75425: Updated patch addressing reviewers concerns and fixing a bug.
https://bugs.webkit.org/attachment.cgi?id=75425&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
Fixed a bug where non fixed sized paren backtrack handling was going to the
outside of the paren code instead of the inside the paren code and a related
issue were some nested paren handling wasn't saving the right backtrack address
on the stack.  Added test cases for this fix.

Addressed the concerns raised from the prior patch.  For point 3, changed the
dataLabelPtr.isUsed() to .isSet(), which is more in keeping with the logic. For
point 4, changed BacktrackDestination::setDataLabelPtr to
setBacktrackDataLabel.