[webkit-reviews] review canceled: [Bug 43852] [Qt] resizeToContent seems to trigger infinite resize on some pages : [Attachment 75273] v3 of the consolidation of patches for qtwebkit-2.1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Dec 2 13:43:16 PST 2010
Ademar Reis <ademar.reis at openbossa.org> has canceled Ademar Reis
<ademar.reis at openbossa.org>'s request for review:
Bug 43852: [Qt] resizeToContent seems to trigger infinite resize on some pages
https://bugs.webkit.org/show_bug.cgi?id=43852
Attachment 75273: v3 of the consolidation of patches for qtwebkit-2.1
https://bugs.webkit.org/attachment.cgi?id=75273&action=review
------- Additional Comments from Ademar Reis <ademar.reis at openbossa.org>
New patch with the latest update from Yael (see previous bug comments)
The diff from the previous patch is:
diff --git a/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp
b/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp
index 275acaa..9426bdc 100644
--- a/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp
+++ b/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp
@@ -279,7 +279,10 @@ void
FrameLoaderClientQt::transitionToCommittedForNewPage()
m_frame->view()->setPaintsEntireContents(page->d->client->viewResizesToContents
Enabled());
// The HistoryController will update the scroll position later if needed.
- m_frame->view()->setActualVisibleContentRect(IntRect(IntPoint::zero(),
currentVisibleContentSize));
+ if (m_frame->view()->paintsEntireContents())
+ m_frame->view()->setActualVisibleContentRect(IntRect(IntPoint::zero(),
currentVisibleContentSize));
+ else
+ m_frame->view()->setActualVisibleContentRect(IntRect());
}
More information about the webkit-reviews
mailing list