[webkit-reviews] review denied: [Bug 50390] Web Inspector: Console records for failed XHRs should contain call stack and request method : [Attachment 75380] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 2 13:26:43 PST 2010


Pavel Feldman <pfeldman at chromium.org> has denied Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 50390: Web Inspector: Console records for failed XHRs should contain call
stack and request method
https://bugs.webkit.org/show_bug.cgi?id=50390

Attachment 75380: Patch
https://bugs.webkit.org/attachment.cgi?id=75380&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=75380&action=review

> WebCore/bindings/js/ScriptCallStackFactory.cpp:55
> +    return 0;

Please remove.

> WebCore/inspector/InspectorResourceAgent.cpp:293
> +    m_requestIdToRequestInfo.set(identifier, info);

I think there is the same code in Timeline. Should it re-use this code?

> WebCore/inspector/InspectorResourceAgent.cpp:302
> +    it->second.httpMethod = request.httpMethod();

FYI: redirect will result in several calls to willSendRequest with same id.
With potentially different http methods. You end up with the resulting one
which is not necessarily what you want.

> WebCore/inspector/InspectorResourceAgent.cpp:344
> +    m_requestIdToRequestInfo.remove(identifier);

Don't forget to make this call in didFailLoading too.

> WebCore/inspector/front-end/inspector.js:-1424
> -	   payload.groupLevel,

Should you remove groupLevel from the native code as well?


More information about the webkit-reviews mailing list