[webkit-reviews] review granted: [Bug 50405] Update ResourceLoaderSet Enumeration : [Attachment 75403] [PATCH] Switch to copyToVector

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 2 12:47:58 PST 2010


Darin Adler <darin at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 50405: Update ResourceLoaderSet Enumeration
https://bugs.webkit.org/show_bug.cgi?id=50405

Attachment 75403: [PATCH] Switch to copyToVector
https://bugs.webkit.org/attachment.cgi?id=75403&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=75403&action=review

> WebCore/loader/DocumentLoader.cpp:64
> +    unsigned count = loadersCopy.size();
> +    for (unsigned i = 0; i < count; ++i)

This should be size_t, not unsigned. The local variable name should be size,
not count.

> WebCore/loader/DocumentLoader.cpp:73
> +    unsigned count = loadersCopy.size();
> +    for (unsigned i = 0; i < count; ++i)

Same here.


More information about the webkit-reviews mailing list