[webkit-reviews] review denied: [Bug 50364] Throw webglcontextlost and webglcontextrestored events when a WebGL context is lost and restored. : [Attachment 75342] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Alexey Marinichev
<amarinichev at chromium.org>'s request for review:
Bug 50364: Throw webglcontextlost and webglcontextrestored events when a WebGL
context is lost and restored.
https://bugs.webkit.org/show_bug.cgi?id=50364

Attachment 75342: Patch
https://bugs.webkit.org/attachment.cgi?id=75342&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
As we've discussed offline you should start a timer when the context is lost --
but only if the user has registered a webglcontextrestored callback on the
canvas. The timer would poll periodically to see whether it can successfully
recreate the context, and once it does, send the webglcontextrestored event.
You can find examples of setting up periodic callbacks in the implementation of
DOMWindow::setInterval (WebCore/page/DOMWindow.cpp). The current implementation
relies on the app making WebGL calls against the lost context in order to
discover that the context has been restored, which isn't supposed to be the
programming model according to the WebGL spec.