[webkit-reviews] review granted: [Bug 50382] [GStreamer] hasVideo/Audio return false until the pipeline reaches PAUSED : [Attachment 75381] proposed patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 50382: [GStreamer] hasVideo/Audio return false until the pipeline reaches
PAUSED
https://bugs.webkit.org/show_bug.cgi?id=50382

Attachment 75381: proposed patch
https://bugs.webkit.org/attachment.cgi?id=75381&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=75381&action=review

Seems reasonable, but please remove the unecessary lines from the destructor.

> WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:396
> +    m_videoTagsTimerHandler = 0;

You shouldn't need to zero this field out in the destructor.

> WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:400
> +    m_audioTagsTimerHandler = 0;

Same here.