[webkit-reviews] review granted: [Bug 50377] [chromium] Remove dead code from PNG encoder : [Attachment 75358] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 2 09:34:59 PST 2010


David Levin <levin at chromium.org> has granted noel gordon
<noel.gordon at gmail.com>'s request for review:
Bug 50377: [chromium] Remove dead code from PNG encoder
https://bugs.webkit.org/show_bug.cgi?id=50377

Attachment 75358: patch
https://bugs.webkit.org/attachment.cgi?id=75358&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=75358&action=review

> WebCore/platform/image-encoders/skia/PNGImageEncoder.cpp:2
> + * Copyright (c) 2010, Google Inc. All rights reserved.

fwiw for some reason, WebKit tends to keep all the years (as opposed to
Chromium which only keeps the most recent). Also, the years are comma separated
and no comma after the last. While this style is followed regularly, I'll admit
that this is a super minor issue, so this is fine for this change.


More information about the webkit-reviews mailing list