[webkit-reviews] review granted: [Bug 50378] Enable DEP at runtime to allow for compatibility with older versions of ATL : [Attachment 75359] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 2 09:07:03 PST 2010


Adam Roben (aroben) <aroben at apple.com> has granted Steve Falkenburg
<sfalken at apple.com>'s request for review:
Bug 50378: Enable DEP at runtime to allow for compatibility with older versions
of ATL
https://bugs.webkit.org/show_bug.cgi?id=50378

Attachment 75359: Patch
https://bugs.webkit.org/attachment.cgi?id=75359&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=75359&action=review

> WebKit2/WebProcess/win/WebProcessMainWin.cpp:45
> +    const DWORD disableATLThunkEmulation = 0x00000002;

Maybe we don't need to declare this, since we don't use it?

> WebKit2/WebProcess/win/WebProcessMainWin.cpp:47
> +    HMODULE hMod = GetModuleHandleW(L"Kernel32.dll");

Please add a :: here.

> WebKit2/WebProcess/win/WebProcessMainWin.cpp:53
> +    PSETDEP procSet = reinterpret_cast<PSETDEP>(GetProcAddress(hMod,
"SetProcessDEPPolicy"));

And here.

> WebKit2/WebProcess/win/WebProcessMainWin.cpp:83
> +    enableDataExecutionPrevention();

Seems like this should go in WebKitMain instead. We already have similar code
there.


More information about the webkit-reviews mailing list