[webkit-reviews] review granted: [Bug 50383] Split DECLARE_ANIMATED_PROPERTY* in DECLARE/DEFINE parts for SVGAnimatedString/SVGAnimatedEnumeration : [Attachment 75373] Patch v2

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 50383: Split DECLARE_ANIMATED_PROPERTY* in DECLARE/DEFINE parts for
SVGAnimatedString/SVGAnimatedEnumeration
https://bugs.webkit.org/show_bug.cgi?id=50383

Attachment 75373: Patch v2
https://bugs.webkit.org/attachment.cgi?id=75373&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=75373&action=review

It would be slightly nicer to do the un-indenting separately.

> WebCore/svg/SVGAElement.h:68
> +    // This defines a non-virtual "String& target() const" method before,
that would clash with "virtual String target() const"
> +    // in Element. That's why it's now named "String& svgTarget() const", to
avoid the clash. The CodeGenerators take care

The first sentence here seems a little garbled. And I think you mean "declares"
instead of "defines".