[webkit-reviews] review requested: [Bug 25770] [chromium] Crash in FontFallbackList::determinePitch(const Font* font) : [Attachment 75345] A copy-and-paste fix (including refactoring)
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 1 18:50:23 PST 2010
Hironori Bono <hbono at chromium.org> has asked for review:
Bug 25770: [chromium] Crash in FontFallbackList::determinePitch(const Font*
font)
https://bugs.webkit.org/show_bug.cgi?id=25770
Attachment 75345: A copy-and-paste fix (including refactoring)
https://bugs.webkit.org/attachment.cgi?id=75345&action=review
------- Additional Comments from Hironori Bono <hbono at chromium.org>
(In reply to comment #6)
> (In reply to comment #5)
> > Do we need refactoring for this file so we can move all these static
functions in this file at the beginning of this file?
>
> Short answer: Sounds good.
Thank you for your comment. I have moved all the static functions at the
beginning of this file because it is pretty easy. (That is, the functionality
is the same as the previous one.) Is it possible to take another look?
Regards,
Hironori Bono
More information about the webkit-reviews
mailing list