[webkit-reviews] review denied: [Bug 50335] Missing DOM property for incremental input attribute : [Attachment 75332] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Erik Arvidsson <arv at chromium.org>'s
request for review:
Bug 50335: Missing DOM property for incremental input attribute
https://bugs.webkit.org/show_bug.cgi?id=50335

Attachment 75332: Patch
https://bugs.webkit.org/attachment.cgi?id=75332&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=75332&action=review

review- because I would prefer that we not add unused functions to the class.
Now that we have Reflect, we don’t need to write C++ getters and setters for
most attributes, although there are exceptions.

> WebCore/html/HTMLInputElement.cpp:1586
> +bool HTMLInputElement::incremental() const
> +{
> +    return fastHasAttribute(incrementalAttr);
> +}
> +
> +void HTMLInputElement::setIncremental(bool incremental)
> +{
> +    setBooleanAttribute(incrementalAttr, incremental);
> +}

These are not needed. No reason to add these.

> WebCore/html/HTMLInputElement.h:198
> +    bool incremental() const;
> +    void setIncremental(bool);

These are not needed. No reason to add these.

> WebCore/html/HTMLInputElement.idl:73
> +	   attribute [Reflect] boolean incremental;

This is enough to fix the bug.