[webkit-reviews] review requested: [Bug 50295] Regexp JIT'ed Code Contains Branches to Branches for Backtracking : [Attachment 75323] Updated Proposed Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 1 14:41:01 PST 2010


Michael Saboff <msaboff at apple.com> has asked  for review:
Bug 50295: Regexp JIT'ed Code Contains Branches to Branches for Backtracking
https://bugs.webkit.org/show_bug.cgi?id=50295

Attachment 75323: Updated Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=75323&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
This patch addresses the concern raised by the prior patch and now uses
UnsignedWithZeroKeyHashTraits<uint32_t>.
Fixed the jump to next instruction in the success case.  Fixed a bug in the
updated fast/regex/pcre tests.
Added ChangeLogs.


More information about the webkit-reviews mailing list