[webkit-reviews] review granted: [Bug 50337] Web Inspector: Inspector protocol cleanup task : [Attachment 75320] [patch] initial version.

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 50337: Web Inspector: Inspector protocol cleanup task
https://bugs.webkit.org/show_bug.cgi?id=50337

Attachment 75320: [patch] initial version.
https://bugs.webkit.org/attachment.cgi?id=75320&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=75320&action=review

> LayoutTests/ChangeLog:5
> +	   clean

Please provide a meaningful message.

> LayoutTests/inspector/report-API-errors-expected.txt:6
> +Protocol Error: the message is for not existing domain 'wrongDomain'

non-existing

> WebCore/inspector/front-end/inspector.js:523
> +    this.domains.Inspector = this;

I don't like "domains" object much. How about:

InspectorBackend.registerDomainDispatcher("Inspector", this);
InspectorBackend.registerDomainDispatcher("Resources",
WebInspector.resourceManager);