[webkit-reviews] review granted: [Bug 47153] CSS 2.1 failure: at-import-* : [Attachment 75313] Fix html4/at-import-010 test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 1 13:53:52 PST 2010


Alexey Proskuryakov <ap at webkit.org> has granted Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 47153: CSS 2.1 failure: at-import-*
https://bugs.webkit.org/show_bug.cgi?id=47153

Attachment 75313: Fix html4/at-import-010 test
https://bugs.webkit.org/attachment.cgi?id=75313&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Somehow, I expected this test to be more controversial, because ":unknownpseudo
{ background: red; }" seems "more valid" than "@page". Weird.

This test doesn't contain any page rules, but you modify
CSSParser::createPageRule().

r=me assuming skipping invalid @page rules matches both IE and Firefox. It's
unfortunate to land this without a test.


More information about the webkit-reviews mailing list