[webkit-reviews] review granted: [Bug 50328] vcproj changes can't be applied cleanly by the Windows EWS bot : [Attachment 75289] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 1 12:47:57 PST 2010


Adam Roben (aroben) <aroben at apple.com> has granted Steve Falkenburg
<sfalken at apple.com>'s request for review:
Bug 50328: vcproj changes can't be applied cleanly by the Windows EWS bot
https://bugs.webkit.org/show_bug.cgi?id=50328

Attachment 75289: Patch
https://bugs.webkit.org/attachment.cgi?id=75289&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=75289&action=review

> .gitattributes:21
> +*.vcproj crlf=crlf
> +*.vsprops crlf=crlf
> +*.sln crlf=crlf
> +

I think that should be "eol=crlf", not "crlf=crlf".

(My guess is that any other Windows-specific files listed in this file should
have svn:eol-style native set on them and then they should be removed from this
file.)


More information about the webkit-reviews mailing list