[webkit-reviews] review requested: [Bug 50344] wss (websockets ssl) support for gtk via new gio TLS support : [Attachment 75301] Update SocketStreamHandleSoup to do wss://

[bugzilla-daemon at webkit.org]

Dan Winship <danw at gnome.org> has asked	for review:
Bug 50344: wss (websockets ssl) support for gtk via new gio TLS support
https://bugs.webkit.org/show_bug.cgi?id=50344

Attachment 75301: Update SocketStreamHandleSoup to do wss://
https://bugs.webkit.org/attachment.cgi?id=75301&action=review

------- Additional Comments from Dan Winship <danw at gnome.org>
Attached patch uses GTlsConnection to make wss:// work. You can test it against
http://websockets.org/echo.html.

(The GPollableOutputStream stuff is basically an abstraction of the previous
GSocket-specific API, that works on both GSocketConnection and GTlsConnection.)


Notably missing from this patch is a change to configure.in to require glib >=
2.27.4 since I wasn't sure how you want to do that. (Currently the support for
gsettings is just conditional on the glib version... so we could do the same
thing here, and continue using the old ws://-only code with older glibs...)