[webkit-reviews] review granted: [Bug 50015] Move regex parsing and fallback handling to runtime/RegExp.cpp : [Attachment 75138] proposed patch v2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 1 10:30:12 PST 2010
Gavin Barraclough <barraclough at apple.com> has granted Peter Varga
<pvarga at inf.u-szeged.hu>'s request for review:
Bug 50015: Move regex parsing and fallback handling to runtime/RegExp.cpp
https://bugs.webkit.org/show_bug.cgi?id=50015
Attachment 75138: proposed patch v2
https://bugs.webkit.org/attachment.cgi?id=75138&action=review
------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
> > we should probably remove the compile method
> I didn't remove the compile method. I think it makes the code seperatable and
now it makes
> the logic of handling RegExp states flexible.
Fine, I'm happy with that decision Peter. Patch looks great, r+.
More information about the webkit-reviews
mailing list