[webkit-reviews] review granted: [Bug 43852] [Qt] resizeToContent seems to trigger infinite resize on some pages : [Attachment 75270] v2 of the consolidation of patches for qtwebkit-2.1

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Ademar Reis
<ademar.reis at openbossa.org>'s request for review:
Bug 43852: [Qt] resizeToContent seems to trigger infinite resize on some pages
https://bugs.webkit.org/show_bug.cgi?id=43852

Attachment 75270: v2 of the consolidation of patches for qtwebkit-2.1
https://bugs.webkit.org/attachment.cgi?id=75270&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=75270&action=review

Looks fine. maybe you want some scrolling tests as well. Or at least make sure
that works.

> WebCore/page/Chrome.cpp:93
> +m_client->delegatedScrollRequested(scrollDelta);

missing indentation

> WebCore/page/FrameView.cpp:353
> +bool FrameView::delegatesScrolling() const
> +{
> +    ASSERT(m_frame);
> +
> +    if (parent())
> +	    return false;
> +
> +    return m_frame->settings() &&
m_frame->settings()->shouldDelegateScrolling();
> +}
> +
> +bool FrameView::avoidScrollbarCreation() const

This code was changed in another patch on trunk... it is not WebCore setting
anymore. you can pick that or leave it

> WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:412
> +emit m_webPage->scrollRequested(delta.width(), delta.height(),
QRect(QPoint(0, 0), m_webPage->viewportSize()));

misses indentation