[webkit-reviews] review denied: [Bug 50223] Web Inspector: refactor SourceFrame to simplify implementing of js beautifier : [Attachment 75264] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 1 07:19:50 PST 2010


Pavel Feldman <pfeldman at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 50223: Web Inspector: refactor SourceFrame to simplify implementing of js
beautifier
https://bugs.webkit.org/show_bug.cgi?id=50223

Attachment 75264: Patch.
https://bugs.webkit.org/attachment.cgi?id=75264&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
This change suffers from several things as we discussed offline:
- too big coupling with source frame via ad-hoc listeners
- not really a controller - more of a breakpoints aspect in
SourceFrameController
- lots of code moved for no good reason.


More information about the webkit-reviews mailing list