[webkit-reviews] review granted: [Bug 50217] [WINCE] add main() function : [Attachment 75152] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 1 06:45:03 PST 2010


Adam Roben (aroben) <aroben at apple.com> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 50217: [WINCE] add main() function
https://bugs.webkit.org/show_bug.cgi?id=50217

Attachment 75152: Patch
https://bugs.webkit.org/attachment.cgi?id=75152&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=75152&action=review

> WebKitTools/WinCELauncher/main.cpp:103
> +    if (fullscreen)
> +	   SetWindowPos(hMainWindow, HWND_TOPMOST, 0, 0,
GetSystemMetrics(SM_CXSCREEN),
> +	       GetSystemMetrics(SM_CYSCREEN), SWP_SHOWWINDOW);

This should be enclosed in braces, since it is more than one line (even though
it's only a single statement).

> WebKitTools/WinCELauncher/main.cpp:123
> +    delete webView;

Could you use an OwnPtr here?


More information about the webkit-reviews mailing list