[webkit-reviews] review denied: [Bug 50225] [GTK] Use gtk_widget_render_icon() to render media buttons using gtk stock icons : [Attachment 75124] Patch to use gtk_widget_render_icon()

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 50225: [GTK] Use gtk_widget_render_icon() to render media buttons using gtk
stock icons
https://bugs.webkit.org/show_bug.cgi?id=50225

Attachment 75124: Patch to use gtk_widget_render_icon()
https://bugs.webkit.org/attachment.cgi?id=75124&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=75124&action=review

Great. Just a couple small issues.

> WebCore/platform/gtk/RenderThemeGtk.cpp:60
> +#define WEBKIT_MEDIA_BUTTON_SIZE "webkit-media-button-size"

I think you should just use this this directly.

> WebCore/platform/gtk/RenderThemeGtk.cpp:77
> +	   RefPtr<BitmapImage> img = BitmapImage::create();
> +	   return img.release();

No need to cache this. You can simply return BitmapImage::create();

> WebCore/platform/gtk/RenderThemeGtk.cpp:91
> +    RefPtr<BitmapImage> img = BitmapImage::create(surface);
> +    return img.release();

Same here, I believe.