[webkit-reviews] review denied: [Bug 50257] [Qt] [WK2] Build system improvements for non-Unix targets : [Attachment 75236] Updated patch for Windows build host and ARMCC flag

[bugzilla-daemon at webkit.org]

Laszlo Gombos <laszlo.1.gombos at nokia.com> has denied Siddharth Mathur
<siddharth.mathur at nokia.com>'s request for review:
Bug 50257: [Qt] [WK2] Build system improvements for non-Unix targets
https://bugs.webkit.org/show_bug.cgi?id=50257

Attachment 75236: Updated patch for Windows build host and ARMCC flag
https://bugs.webkit.org/attachment.cgi?id=75236&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
This patch does not seems to apply cleanly to the trunk, r- for that.

Also, have you successfully used --preinclude in any environment ? If not than
this code is speculative and I think we should not land it until we used it
successfully. 

Perhaps you can resolve the conflict with the trunk and resubmit the patch
without the "--preinclude" changes.