[webkit-reviews] review granted: [Bug 36299] Volume control not correctly initialized : [Attachment 75259] updated patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 36299: Volume control not correctly initialized
https://bugs.webkit.org/show_bug.cgi?id=36299

Attachment 75259: updated patch
https://bugs.webkit.org/attachment.cgi?id=75259&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=75259&action=review

Only one small issue, but it's fine to fix before landing it.

> WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:618
> +    m_volumeTimerHandler = 0;

I think this should happen before the early return.

> WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1197
> +    m_muteTimerHandler = 0;

Same here.