[webkit-reviews] review granted: [Bug 44955] Prepare RenderSVGContainer culling patch : [Attachment 66057] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 31 23:04:38 PDT 2010


Dirk Schulze <krit at webkit.org> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 44955: Prepare RenderSVGContainer culling patch
https://bugs.webkit.org/show_bug.cgi?id=44955

Attachment 66057: Patch
https://bugs.webkit.org/attachment.cgi?id=66057&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
Great that you split more parts out of the original patch. Just rephrase the
first sentence in your Cahngelog. "Add styleWillChange methods ... if the style
difference is StyleDifferenceLayout" The if sounds a bit strange here. And you
should mention that the follow-up patch will cache the rects for container.
Souds like a feature for the far future here :-)

r=me


More information about the webkit-reviews mailing list