[webkit-reviews] review denied: [Bug 44759] [EFL] Add custom network resource handler : [Attachment 65700] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Flavio Ceolin
<flavio.ceolin at profusion.mobi>'s request for review:
Bug 44759: [EFL] Add custom network resource handler
https://bugs.webkit.org/show_bug.cgi?id=44759

Attachment 65700: Patch
https://bugs.webkit.org/attachment.cgi?id=65700&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=65700&action=prettypatch

> WebCore/loader/FrameLoader.cpp:3523
> +#if PLATFORM(EFL)
> +bool FrameLoaderClient::shouldHandleScheme(const String& scheme)
> +{
> +    return false;
> +}
> +
> +void* FrameLoaderClient::handleScheme(const KURL url, String& mime, size_t*
bytesRead)
> +{
> +    return 0;
> +}
> +#endif
These implementations are misplaced.  Why are you putting FrameLoaderClient
impls in FrameLoader.cpp?

> WebCore/loader/FrameLoaderClient.h:271
> +#if PLATFORM(EFL)
> +	   virtual bool shouldHandleScheme(const String&);
> +	   virtual void* handleScheme(const KURL, String&, size_t*);
> +#endif
Why would these functions be EFL-specific?  I don't think these make sense
here.

> WebCore/platform/network/soup/ResourceHandleSoup.cpp:131
> +#if PLATFORM(EFL)
> +static bool startPersonalHandler(ResourceHandle* handle, KURL url);
> +#endif
Adding EFL ifdefs to ResourceHandleSoup isn't the right approach.