[webkit-reviews] review denied: [Bug 42058] [BREWMP] Don't pass PassOwnPtr in makeAllDirectories : [Attachment 65717] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Kwang Yul Seo
<kwangyul.seo at gmail.com>'s request for review:
Bug 42058: [BREWMP] Don't pass PassOwnPtr in makeAllDirectories
https://bugs.webkit.org/show_bug.cgi?id=42058

Attachment 65717: Patch
https://bugs.webkit.org/attachment.cgi?id=65717&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=65717&action=prettypatch

> WebCore/platform/brew/FileSystemBrew.cpp:134
> -static bool makeAllDirectories(PassOwnPtr<IFileMgr> fileMgr, const String&
path)
> +static bool makeAllDirectories(IFileMgr* rawFileMgr, const String& path)
rawFileMgr isn't the right name here, for sure.  Perhaps fileManager?  I'd have
to look at the larger context to see what the memory ownership is like here.