[webkit-reviews] review requested: [Bug 45015] Add helpers to FloatRect to compute bounding box from points : [Attachment 66159] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 31 19:19:59 PDT 2010
Kenneth Russell <kbr at google.com> has asked for review:
Bug 45015: Add helpers to FloatRect to compute bounding box from points
https://bugs.webkit.org/show_bug.cgi?id=45015
Attachment 66159: Patch
https://bugs.webkit.org/attachment.cgi?id=66159&action=review
------- Additional Comments from Kenneth Russell <kbr at google.com>
>From the ChangeLog:
Added fitToPoints, including a few overloaded variants for the cases of two,
three and four points. I opted not to add a generalized version taking const
FloatRect* or Vector<FloatRect> at the present time because for my own purposes
they are unnecessary, and the specific versions can be more tightly coded. Also
added left() and top() for symmetry with right() and bottom(). These changes
have been tested with new code to be added later.
More information about the webkit-reviews
mailing list