[webkit-reviews] review granted: [Bug 44982] ews: Add support for EFL-EWS : [Attachment 66100] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 31 16:40:10 PDT 2010
Adam Barth <abarth at webkit.org> has granted Leandro Pereira
<leandro at profusion.mobi>'s request for review:
Bug 44982: ews: Add support for EFL-EWS
https://bugs.webkit.org/show_bug.cgi?id=44982
Attachment 66100: Patch
https://bugs.webkit.org/attachment.cgi?id=66100&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=66100&action=prettypatch
> WebKitTools/Scripts/webkitpy/tool/commands/earlywarningsystem.py:114
> +class EflEWS(AbstractEarlyWarningSystem):
> + name = "efl-ews"
> + port_name = "efl"
Does the EFL port run on more than one platform? If so, you might want to
consider a name like efl-win-ews. Once you pick a name, you're stuck with it.
:)
More information about the webkit-reviews
mailing list