[webkit-reviews] review denied: [Bug 39582] [Cairo] Enhance the performance of shadowed elements by tiling the shadow area : [Attachment 66129] Proposed patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Alejandro G. Castro
<alex at igalia.com>'s request for review:
Bug 39582: [Cairo] Enhance the performance of shadowed elements by tiling the
shadow area
https://bugs.webkit.org/show_bug.cgi?id=39582

Attachment 66129: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=66129&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
> WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:630
> +    if ((transform.isIdentityOrTranslationOrFlipped())) {
> +	   cairo_t* cr = context->platformContext();;
Avoid multiple braces and muliple semicolons.

> WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:633
> +	   FloatSize corner(0, 0);
No need for (0, 0), just use FloatSize corner;

> WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:1330
> +    OwnPtr<ImageBuffer> smallBuffer = ImageBuffer::create(smallBufferSize);
You should check if we realy got an imagebuffer.

> WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:1340
> +    OwnPtr<ImageBuffer> shadowBuffer = ImageBuffer::create(smallBufferSize);

dito

> WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:1378
> +    shadowBuffer->drawPattern(this, tileRect, patternTransform,
can be in one line

> WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:1388
> +    shadowBuffer->drawPattern(this, tileRect, patternTransform,
> +				 phase, colorSpace, CompositeSourceOver,
destRect);
dito

> WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:1397
> +    shadowBuffer->drawPattern(this, tileRect, patternTransform,
> +				 phase, colorSpace, CompositeSourceOver,
destRect);
dito

> WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:1405
> +    shadowBuffer->drawPattern(this, tileRect, patternTransform,
> +				 phase, colorSpace, CompositeSourceOver,
destRect);
dito

> WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:1413
> +    shadowBuffer->drawPattern(this, tileRect, patternTransform,
> +				 phase, colorSpace, CompositeSourceOver,
destRect);
dito

> WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:1421
> +    shadowBuffer->drawPattern(this, tileRect, patternTransform,
> +				 phase, colorSpace, CompositeSourceOver,
destRect);
dito

> WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:1429
> +    shadowBuffer->drawPattern(this, tileRect, patternTransform,
> +				 phase, colorSpace, CompositeSourceOver,
destRect);
dito