[webkit-reviews] review denied: [Bug 44917] [chromium] Implement Readable/Writable versions of ChromiumDataObjectNew : [Attachment 66104] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Daniel Cheng <dcheng at chromium.org>'s
request for review:
Bug 44917: [chromium] Implement Readable/Writable versions of
ChromiumDataObjectNew
https://bugs.webkit.org/show_bug.cgi?id=44917

Attachment 66104: Patch
https://bugs.webkit.org/attachment.cgi?id=66104&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
> +++ b/WebCore/platform/chromium/ClipboardMimeTypes.h
> +const char* const textPlainType = "text/plain";
> +const char* const textHtmlType = "text/html";
> +const char* const textUriListType = "text/uri-list";

This is the wrong way to make shared strings.  By putting the data in the
header, the value will be copied into each .cpp file that includes this file. 
An example of chromium code that does this is in base/base_switches.*. 
Alternately, I would stick these values as static variables off an existing
class.